Nightmode

[pauloconnor]

There are a few elements that don't change for nightmode, in particular buttons and drop downs but it's designed more for fullscreen of dashboard. Nightmode will persist while selecting Fullscreen.

Addresses https://github.com/obfuscurity/descartes/issues/109

[obfuscurity]

I love that you took a stab at this already. Awesome stuff. However, I feel that nightmode should really be a global per-user setting; that is to say, there should be a button somewhere that a user clicks to enable this mode and then all pages should be styled accordingly. It shouldn't be something that you click on the graphs page and then lose by clicking over to the dashboards page. That's a pretty jarring experience imho.

A few other random thoughts:

• We already have a GRAPH_TEMPLATE setting for the default view. We need to add a GRAPH_TEMPLATE_DARK or similar for nightmode.
• Needs a full-blown styling treatment for buttons, panels, etc. May require some refactoring to do this right (e.g. for buttons that use :inverse on activation.
• If we're going to have a normal mode and a night mode, why stop there? Perhaps we should consider abstracting out templates. This would be a lot more work upfront, but would justify adding a menu select in the navbar to choose between visual modes.

[obfuscurity]

I finally got around to playing around with this today (sorry!) and I like the initial work here. I think there are some issues that would need to be resolved before this gets merged in, but it's a good start. I won't blame you if you don't feel like hacking on this any more, but I intend to use it as a starting point whenever I get back around to this feature.

Some notes to self:

• The button change state should be more visually pronounced. Currently it changes to a different icon. I think it should also change color to inverse, the way we do when we open dialogs and such.
• Graphs should also change their appearance. It's a start contrast when everything goes black except for the graphs which are still painfully white in this mode. We should have a default nightmode graph template, but allow users to specify an override graph template.

[pauloconnor]

I had a properly working version of this written at Monitorama EU but I lost the changes :( I'll try and get back to this soon.

[obfuscurity]

NOOOOOOOOOOO!!!

[pauloconnor]

This is what I'm thinking for nightmode.

Comments?

[obfuscurity]

That looks really good. My only change would be to try and make the toolbar more subtle.

[pauloconnor]

Agreed. That will be non-trivial though - the icons are white so I'll have a think about that. Let me push this code so you can have a play and see what you think.

[obfuscurity]

Check out some of the stuff you can do with css transforms, I bet that would help.

Jason

On Fri, Nov 15, 2013 at 10:05:23AM -0800, pauloconnor wrote:

Agreed. That will be non-trivial though - the icons are white so I'll have a think about that. Let me push this code so you can have a play and see what you think.

---

Reply to this email directly or view it on GitHub: https://github.com/obfuscurity/descartes/pull/135#issuecomment-28590069

Jason Dixon http://obfuscurity.com/ https://twitter.com/obfuscurity

[pauloconnor]

[obfuscurity]

Better. I'd still go a bit darker. They're easily the most prominent thing on the page. I mean, it's not the worst thing in the world if it gets merged as-is. I can always tweak it in the tree. :smile_cat:

[pauloconnor]

I've made the text match the header links. I've also darkened the background for the well.

[scalp42]

[obfuscurity]

[scalp42]

unrelated to anything I feel like I know you since 2012 @obfuscurity (dont think you ever changed your profile picture 😂)

[damm]

Blast from the past to even get a notification on issues related to graphite for me.