search

obfuscurity / descartes

Introspective dashboard for Graphite
MIT License
504 stars 65 forks source link

delete extraneous html (lolhaml) fixes #60 #63

Closed brntbeer closed 12 years ago

brntbeer commented 12 years ago

collapsed graph possibly looks better this way?

bettar

brntbeer commented 12 years ago

There's still tons of things to fix on these forms, lots of code that is repeated/already accomplished by bootstrap natively. Started going down the rabbit hole with @ajacksified, may convince him through absurd amounts of food and alcohol to fix this.

obfuscurity commented 12 years ago

This really isn't in a state to merge. The functionality still works (e.g. importing a URL) but the styling is broken in a bunch of different ways.

P.S. Including things like the warning message in "graph delete mode".

brntbeer commented 12 years ago

When you say functionality still broken in a number of ways, do you mean like "yes brent, good job here's a :cookie:, however the larger issue is the styling broken not just on this page but many pages for the same reason that this issue was caused" ?

After sleeping, and re-reading #60, i possible just sent this too soon. I'm almost glad i did because of starting discussion on the WIP though!

Could you expand on your "P.S" ? not sure i follow.

obfuscurity commented 12 years ago

First off, here's a :cookie:.

I never said functionality was broken. I said that the change broke a lot of the styles. Missing margins, the graph-delete dialog is no longer styled, etc.

brntbeer commented 12 years ago

ah, totally missed that. sorry to not be so thorough!

obfuscurity commented 12 years ago

I'm closing this as incomplete. Feel free to resubmit when it's in a better state.