search

obfuscurity / descartes

Introspective dashboard for Graphite
MIT License
502 stars 65 forks source link

No HTTP Authorization Header for Graphs #74

Closed loe closed 11 years ago

loe commented 11 years ago

Not sure how you solve this, as the image tags are handled by the browser. But if I have not authenticated with my graphite server (which is behind HTTP Auth) all the images are broken. Things like importing work though.

obfuscurity commented 11 years ago

I've been pushing this off since the goal is to move all graphs to client-side rendering. But as I don't have a good timetable for that, I'll probably introduce something in the short term as a workaround.

I have a working copy that injects the creds into the uri via constructGraphUrl() (render-common.js), but I don't like this because it adds the creds to every single graph url we ever load. Rather, I'd like to find some way to submit/cache these creds once we create our session. It seems that the browser ignores the creds if they're only submitted via ajax, so we need some other way to do this "in browser", before we attempt to load any other Graphite assets, and without degrading the rest of the user workflow. Thinking...

/cc @antonlindstrom

obfuscurity commented 11 years ago

Screw it. Temporary workarounds were designed to be ugly. :wink:

antonlindstrom commented 11 years ago

Cheers man, it's either that or run it via a proxy that injects the creds.

obfuscurity commented 11 years ago

@antonlindstrom Well, the "solution" I was pondering was a quick redirect to a page that loaded /content/js/ext/resources/images/default/s.gif (1x1 gif) and then redirected back to the original request. But that was increasingly ugly and might have even been a hassle to remove later on.