obfuscurity / descartes

Introspective dashboard for Graphite
MIT License
502 stars 65 forks source link

yStep Parameter Lost #80

Closed dmourati closed 11 years ago

dmourati commented 11 years ago

I create a graph interactively on the url and then import it into Descartes (Graphis->Import Graphs->Graph URL) to save it. I need to specify yStep.

http://graphite.eye.fi/render/?height=300&width=1170&from=-1d&target=Equinix.SJC_DB.db5b_eye_fi.EVENT_TYPE_ITEM_TAGGED&target=Equinix.SJC_DB.db5b_eye_fi.EVENT_TYPE_ITEM_FAVORITED&lineMode=slope&areaMode=stacked&drawNullAsZero=false&noCache=true&template=solarized-light&hideLegend=false&yStep=1

After import, Descartes version of the url looks like:

http://graphite.eye.fi/render/?height=300&width=1170&from=-1d&target=Equinix.SJC_DB.db5b_eye_fi.EVENT_TYPE_ITEM_TAGGED&target=Equinix.SJC_DB.db5b_eye_fi.EVENT_TYPE_ITEM_FAVORITED&lineMode=slope&areaMode=stacked&drawNullAsZero=false&noCache=true&hideLegend=true&template=solarized-light&hideLegend=false

obfuscurity commented 11 years ago

The original setting is saved in the original url value as well as the parsed configuration column, but we don't support that in the reconstructed graph url or UI yet. It would be trivial to add that to the graph output, but it'll take more work to make it a configurable setting in the UI. I'd rather not add these "minor" settings in the background without a cohesive plan for adding their counterparts in the UI as well.

Long story short, it would be easy to add support for missing Graphite params in the output, but you wouldn't be able to modify those settings in Descartes for now. Is that a concern for you?

Sample import:

url           | https://graphite.example.com/render/?width=586&height=308&_salt=1362694373.93&from=-3days&title=CPU&target=alias(scale(sumSeries(graphite-example-com.*.cpu-softirq.value)%2C0.25)%2C%22softirq%22)&yStepLeft=0.05
configuration | {"width":"586","height":"308","_salt":"1362694373.93","from":"-3days","title":"CPU","target":["alias(scale(sumSeries(graphite-example-com.*.cpu-softirq.value),0.25),\"softirq\")"],"yStepLeft":"0.05"}