search

obfuscurity / descartes

Introspective dashboard for Graphite
MIT License
502 stars 65 forks source link

Graphite port is not passed correctly when rendering graphs #96

Closed chrisboulton closed 11 years ago

chrisboulton commented 11 years ago

I noticed this while redoing my development setup tonight where graphite is listening on a port other than 80.

Simply ensure the port is always passed when rendering a graph in the browser.

:heart:

chrisboulton commented 11 years ago

Sigh, don't merge this yet - my sleepy self just broke graphs loaded over SSL.

chrisboulton commented 11 years ago

Fixed.

> url = parseUrl('http://www.google.com/'); url.protocol + ' ' + url.port
"http 80"
> url = parseUrl('https://www.google.com/'); url.protocol + ' ' + url.port
"https 443"
> url = parseUrl('https://www.google.com:1234/'); url.protocol + ' ' + url.port
"https 1234"
> url = parseUrl('http://www.google.com:1234/'); url.protocol + ' ' + url.port
"http 1234"
chrisboulton commented 11 years ago

Whoops - old habits die hard. Fixed. :squirrel:

obfuscurity commented 11 years ago

:boom: :wine_glass: :zap: :cherries: