search

obfuscurity / judy

Bespoke service for reviewing CFP submissions
http://obfuscurity.github.io/judy
Other
25 stars 6 forks source link

Support for Comments #28

Closed patcable closed 8 years ago

patcable commented 8 years ago

This adds support for reviewer comments (#14). Reviews now have a field for adding a comment along with the scoring. It looks something like this: judycomment

To give the best at an untainted submission review, I moved the list of comments to the "scores" page: clist.

obfuscurity commented 8 years ago

I haven't had a chance to really dig into this yet but at a glance it looks fine. How does it treat empty/null comments?

patcable commented 8 years ago

Null comments are fine, score is still logged. Forgot to kill off the null comments in the scoring view, but fixed that in 2d0a1c8.

obfuscurity commented 8 years ago

You're using this now for DoD Boston?

patcable commented 8 years ago

nope -- LISA16 (but in Boston this year)

obfuscurity commented 8 years ago

Oh, one thing I'd add if you have time/interest... something like text-overflow: ellipsis (https://developer.mozilla.org/en-US/docs/Web/CSS/text-overflow) for limiting the number of characters in the score/comment view. What's the current behavior?

obfuscurity commented 8 years ago

Note that I'm happy to bring it in as is... didn't mean to sound greedy or demanding. I'm really grateful for the contribution here. :heart:

patcable commented 8 years ago

Oh not a problem -- just wanted to see what the current behavior was before responding. Currently, long winded commenters are just going to wrap and span the whole container (from score to the right edge of the sessions button). Might try and play with paragraph formatting in a few.

patcable commented 8 years ago

Yeah, I wasn't quite sure how to fix the long span. I don't think our reviewers are going to go too crazy (famous last words) -- but also, my css-fu is a bit weak to get everything working a way that would look better. Future work? :)

obfuscurity commented 8 years ago

Yeah, no problem.

obfuscurity commented 8 years ago

Thanks again :cake: 🍦