obfuscurity / judy

Bespoke service for reviewing CFP submissions
http://obfuscurity.github.io/judy
Other
25 stars 6 forks source link

Heroku deploy requires newer ruby version #36

Closed jeffreyscarpenter closed 5 years ago

jeffreyscarpenter commented 5 years ago

When I used the "Deploy to Heroku" button from the README page, I received the following error in the Heroku build log:

-----> Ruby app detected -----> Compiling Ruby/Rack Command: 'set -o pipefail; curl -L --fail --retry 5 --retry-delay 1 --connect-timeout 3 --max-time 30 https://s3-external-1.amazonaws.com/heroku-buildpack-ruby/heroku-18/ruby-2.2.7.tgz -s -o - | tar zxf - ' failed on attempt 1 of 3. Command: 'set -o pipefail; curl -L --fail --retry 5 --retry-delay 1 --connect-timeout 3 --max-time 30 https://s3-external-1.amazonaws.com/heroku-buildpack-ruby/heroku-18/ruby-2.2.7.tgz -s -o - | tar zxf - ' failed on attempt 2 of 3. ! ! An error occurred while installing ruby-2.2.7 !
! This version of Ruby is not available on Heroku-18. The minimum supported version ! of Ruby on the Heroku-18 stack can found at: !
! https://devcenter.heroku.com/articles/ruby-support#supported-runtimes ! ! Push rejected, failed to compile Ruby app. ! Push failed

The supported runtimes page cited above indicates at least Ruby 2.4.5 will be required. I've been able to reproduce this error locally. I am running into compile errors when I try upgrading Ruby.

obfuscurity commented 5 years ago

I'll try to take a look at it this weekend. Thanks for the report!

On Sat, Feb 23, 2019 at 12:15 AM Jeffrey Carpenter notifications@github.com wrote:

When I used the "Deploy to Heroku" button from the README page, I received the following error in the Heroku build log:

-----> Ruby app detected -----> Compiling Ruby/Rack Command: 'set -o pipefail; curl -L --fail --retry 5 --retry-delay 1 --connect-timeout 3 --max-time 30 https://s3-external-1.amazonaws.com/heroku-buildpack-ruby/heroku-18/ruby-2.2.7.tgz -s -o - | tar zxf - ' failed on attempt 1 of 3. Command: 'set -o pipefail; curl -L --fail --retry 5 --retry-delay 1 --connect-timeout 3 --max-time 30 https://s3-external-1.amazonaws.com/heroku-buildpack-ruby/heroku-18/ruby-2.2.7.tgz -s -o - | tar zxf - ' failed on attempt 2 of 3. ! ! An error occurred while installing ruby-2.2.7 ! ! This version of Ruby is not available on Heroku-18. The minimum supported version ! of Ruby on the Heroku-18 stack can found at: ! ! https://devcenter.heroku.com/articles/ruby-support#supported-runtimes ! ! Push rejected, failed to compile Ruby app. ! Push failed

The supported runtimes page cited above indicates at least Ruby 2.4.5 will be required. I've been able to reproduce this error locally. I am running into compile errors when I try upgrading Ruby.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/obfuscurity/judy/issues/36, or mute the thread https://github.com/notifications/unsubscribe-auth/AAeLAmk1XZez5p-pv0Uh_KfHr20xJNJ0ks5vQM6CgaJpZM4bNwDl .

-- Jason Dixon http://obfuscurity.com/ https://twitter.com/obfuscurity

obfuscurity commented 5 years ago

Confirmed that the Heroku button works again after merging fixes in #37.

jeffreyscarpenter commented 5 years ago

Works great! Thanks much for fast response on the weekend.