search

obfuscurity / tasseo

Live dashboard for Graphite
Other
1.53k stars 127 forks source link

Initial values drawn at wrong end of the graph #14

Closed bwhaley closed 12 years ago

bwhaley commented 12 years ago

I have a metric in which 0 indicates a healthy value. Whenever the value rises above 0, I notice that the graph first populates on the left side (where the text is) before being redrawn at the correct location on the right side of the graph. Let me know if this isn't clear enough..

obfuscurity commented 12 years ago

I've also observed this. This is a bug within the "compensating" logic that applies non-null values to the leading datapoint.

obfuscurity commented 12 years ago

Just discovered the keepLastValue function in Graphite. This should allow us to rip out the "padding" code and avoid the nulls. Perhaps it can even be a per-dashboard option, we'll see.

http://graphite.readthedocs.org/en/1.0/functions.html#graphite.render.functions.keepLastValue

danp commented 12 years ago

Maybe related, it would be nice as well if when watching a graph that had good data there was some indication if new data becomes unavailable. If graphite starts returning null values I guess that would be? A start might be the numeric display changing to "ND" or similar, cooler would be the "no data" portions of the graph blocked off in a different color.

obfuscurity commented 12 years ago

@bwhaley Can you try the padnulls branch and let me know if it looks good for you?

obfuscurity commented 12 years ago

Looking at results from @dpiddy and my own testing I feel confident that this fixes it. Merging into master.