search

obfuscurity / tasseo

Live dashboard for Graphite
Other
1.53k stars 127 forks source link

Reorganize to allow for alternate datasources #64

Closed eric closed 11 years ago

eric commented 11 years ago

This change is intended to provide a way to implement alternate backends for tasseo.

The javascript has been split into 3 classes:

  1. TasseoDashboard which is responsible for a collection of graphs
  2. TasseoGraphiteDatasource which is responsible for fetching data from graphite
  3. TasseoUi which is responsible for switching periods as well as day/night mode

Much of the code that was in j/tasseo.js that used global variables to configure aspects of operation have been moved to index.haml to allow for j/tasseo.js to be loaded in places that need more control over operation.

obfuscurity commented 11 years ago

@eric Is this the first step towards refactoring backends?

/cc @roidrage

obfuscurity commented 11 years ago

@eric Never mind, after reading the issue title again I see that's clearly your intent. I assume at some point we'll see a PR for TasseoLibratoDatasource?

eric commented 11 years ago

Correct. Once this is merged I'll work on more datasources.

I have currently written a datasource to display realtime stats directly from a process that exposes metric snapshots via JSON.

eric commented 11 years ago

I forgot to mention that I don't have a graphite install to actually test the graphite part against, though I was able to see that it was getting 404's.

Do you have a public graphite install I could point this at to ensure there aren't any other bugs lurking?

obfuscurity commented 11 years ago

@eric Yeah you can use mine. I've sent you the creds offline.

eric commented 11 years ago

I've tested everything I can against graphite and it looks good to me.

eric commented 11 years ago

I've included a Librato Metrics datasource (based on the work of @roidrage in #31 and #58) as TasseoLibratoDatasource to demonstrate how other datasources would work.

Please let me know if you see any issues that would prevent this from being merged. I would love to get this out there.

roidrage commented 11 years ago

I endorse this pull request!

obfuscurity commented 11 years ago

@eric @roidrage Added both of you as collaborators.

@eric Would you mind updating the README to reflect the new stuff (Librato, generic backend support)?

eric commented 11 years ago

Sounds great! Will do.

On Mon, Aug 26, 2013 at 7:53 AM, Jason Dixon notifications@github.com wrote:

@eric @roidrage Added both of you as collaborators.

@eric Would you mind updating the README to reflect the new stuff (Librato, generic backend support)?

Reply to this email directly or view it on GitHub: https://github.com/obfuscurity/tasseo/pull/64#issuecomment-23267765