Refactors event handler

[SuchAFuriousDeath]

I guess VmmEventHandle will have to wrap an impl FnMut(VmmEvent) + Clone closure? Or something like that.

[ultimaweapon]

I guess VmmEventHandle will have to wrap an impl FnMut(VmmEvent) + Clone closure?

Should be Arc<dyn Fn(...)> instead.

[SuchAFuriousDeath]

I guess VmmEventHandle will have to wrap an impl FnMut(VmmEvent) + Clone closure?

Should be Arc<dyn Fn(...)> instead.

Close enough :sweat_smile:

[ultimaweapon]

I don't think global models are a good idea. Why do we need it? It should be passing to the main window and downstream to all of its children instead.

[SuchAFuriousDeath]

I don't think global models are a good idea. Why do we need it? It should be passing to the main window and downstream to all of its children instead.

When launching in debug, there is no main window (and the screen isn't its child anyway). Maybe that's the fix that needs fixing here :thinking:

[SuchAFuriousDeath]

I don't think global models are a good idea. Why do we need it? It should be passing to the main window and downstream to all of its children instead.

When launching in debug, there is no main window (and the screen isn't its child anyway). Maybe that's the fix that needs fixing here 🤔

But that's actually not the real problem. The real 'problem' is that I don't like having to pass the devices and profiles through several elements down to where we actually need them. If they're global, we can just directly access them right where we need them (in the ComboBoxes)

[ultimaweapon]

I don't think global models are a good idea. Why do we need it? It should be passing to the main window and downstream to all of its children instead.

When launching in debug, there is no main window (and the screen isn't its child anyway). Maybe that's the fix that needs fixing here 🤔

But that's actually not the real problem. The real 'problem' is that I don't like having to pass the devices and profiles through several elements down to where we actually need them. If they're global, we can just directly access them right where we need them (in the ComboBoxes)

What you don't like here are actually a good practice.

[SuchAFuriousDeath]

I don't think global models are a good idea. Why do we need it? It should be passing to the main window and downstream to all of its children instead.

When launching in debug, there is no main window (and the screen isn't its child anyway). Maybe that's the fix that needs fixing here 🤔

But that's actually not the real problem. The real 'problem' is that I don't like having to pass the devices and profiles through several elements down to where we actually need them. If they're global, we can just directly access them right where we need them (in the ComboBoxes)

What you don't like here are actually a good practice.

Oops :D