Closed SuchAFuriousDeath closed 6 months ago
@ultimaweapon What do you think about using OwnedFd in HostFile?
@ultimaweapon FYI, we currently fail on looking up libkernel
I'm past that, now the read seems to fail
Ok, I got the path wrong, so I was trying to read a directory, oops. Now we're failing at devfs getattr which is being called by revoke :heart_eyes:
We're currently stuck at opening dipsw, which isn't implemented for us
Closing this as it has been split into several smaller PRs
This is more of a rough sketch. I had the VnodeBackend::open in mind a long time ago. I think that if you look at implementations of vop_open, the file* is basically passed to them just so that they can call finit on it, which is the equivalent of returning the filetype and setting it in open as I did.
This PR
I'll be gradually splitting this into multiple PRs so that it's easier to review.
Things to consider: Is it ok to do pwritev every time in HostFile? It's probably possible to store the next expected offset and if it matches the provided one, do a simple writev.