search

obhq / obliteration

Experimental PS4 emulator written in Rust for Windows, macOS and Linux
https://obliteration.net
MIT License
586 stars 17 forks source link

Properly implement the TIOCSCTTY ioctl #795

Open SuchAFuriousDeath opened 3 months ago

SuchAFuriousDeath commented 3 months ago

This is a standard FreeBSD ioctl. I decided to conciously skip it for now, because: 1) The code would be really messy with a lot of .read() and .write() and .unwrap 2) We would have to use Weak pointers to prevent memory leaks, causing even more unwraps 3) It doesn't produce any output or affect any internal state that affects anything else (as far as we know) 4) previously,before the filesystem rework, this was also skipped and nothing bad happened.

Under these circumstances, I believe it's justifiable to postpone the implementation of this until it is required. We already got stuck on the filesystem for such a long time and I don't want to get stuck on this right now.

SuchAFuriousDeath commented 3 months ago

This is not needed anymore after #810

ultimaweapon commented 3 months ago

This one is going to be needed when we supports running the PS4 firmware so I'll re-open this.

SuchAFuriousDeath commented 3 months ago

When do you intend to begin working on that, if I may ask?

ultimaweapon commented 3 months ago

Once I finished migrating the game to run inside a VM.