obhq / obliteration

Experimental free and open-source PlayStation 4 kernel
https://obliteration.net
Apache License 2.0
621 stars 17 forks source link

Uses clap builder to parse kernel arguments #865

Closed ultimaweapon closed 4 months ago

ultimaweapon commented 4 months ago

The reason is because clap derive does not supports default value from Default trait (AFAIK), which we required for IDPS.

SuchAFuriousDeath commented 4 months ago

maybe default_value_t = Default::default?

SuchAFuriousDeath commented 4 months ago

Also, have you tried this?

image

ultimaweapon commented 4 months ago

maybe default_value_t = Default::default?

Not working.

Also, have you tried this?

image

Not tried without = yet but I think the builder pattern is better here because it does not require std::fmt::Display implementation on the type.