search

obi-ml-public / ehr_deidentification

Robust de-identification of medical notes using transformer architectures
MIT License
42 stars 10 forks source link

is the typing dependency needed #4

Closed matthewchung74 closed 2 years ago

matthewchung74 commented 2 years ago

Do you still need this typing~=3.10.0.0 in requirements.txt?

per here https://pypi.org/project/typing/

NOTE: in Python 3.5 and later, the typing module lives in the stdlib, and installing this package has NO EFFECT, because stdlib takes higher precedence than the installation directory. To get a newer version of the typing module in Python 3.5 or later, you have to upgrade to a newer Python (bugfix) version. For example, typing in Python 3.6.0 is missing the definition of ‘Type’ – upgrading to 3.6.2 will fix this.

and I see 3.7 is a dependency in the Conda file.

prajwal967 commented 2 years ago

You're right, the typing dependency is not explicitly needed. We generated the requirements file and it must have got in there somehow.

matthewchung74 commented 2 years ago

It ok if I send another MR for it?

prajwal967 commented 2 years ago

Sorry, I missed this earlier. Yes, you can send a pull request, and we can merge it. Thanks!