obi-ontology / obi

The Ontology for Biomedical Investigations
http://obi-ontology.org
Creative Commons Attribution 4.0 International
75 stars 27 forks source link

NTR: Oxford Nanopore Sequencing Platforms #1086

Closed bonitalam closed 4 years ago

bonitalam commented 4 years ago

Project: ENCODE

Oxford Nanopore has developed a number of small affordable sequencing instruments that allow labs to sequence their own samples without sending them to sequencing centers that run much larger and pricier sequencers. We would like to some NTRs for their platforms.

NTR: "Oxford Nanopore MinION"

NTR: "Oxford Nanopore GridION Mk1"

NTR: "Oxford Nanopore PromethION"

DanBerrios commented 4 years ago

@bonitalam These mostly look correct, Bonita. For Examples of usage, we generally put in natural language uses of the term/concept, not references to (in this case, equipment) usage in practice. So I will find some examples of natural language and replace.
Do we need a separate concept for "nanopore" or "nanopore technology"? I think so.... Would this suffice? http://www.ontobee.org/ontology/NCIT?iri=http://purl.obolibrary.org/obo/NCIT_C62343

bonitalam commented 4 years ago

@DanBerrios thank you for letting me know about examples of usage, I will keep that in mind for future requests.

I think your suggestion for a separate concept to capture "nanopore" is correct, and the NCI term looks to describe it adequately.

DanBerrios commented 4 years ago

EFO now has all these ONT concepts...would suggest straight import:

http://www.ebi.ac.uk/efo/EFO_0008633 http://www.ebi.ac.uk/efo/EFO_0008632 http://www.ebi.ac.uk/efo/EFO_0008634

. What else do you need to import them?

jamesaoverton commented 4 years ago

OBI doesn't import from EFO, for two main reasons:

  1. EFO is not an OBO ontology
  2. EFO imports from OBI, which would mean circular imports, which causes various problems

2 is more important than 1. We could revise this policy/practise but we need to mitigate the problems from 2.

In the past, we have often defined new OBI terms and given EFO credit as the definition source.

DanBerrios commented 4 years ago

@jamesaoverton @bonitalam Will it meet users' needs to just have them in EFO? If so, then we don't need to do anything for this issue...

bonitalam commented 4 years ago

@DanBerrios for us, we only use OBI to annotate our assays/platforms. We would like to avoid using EFO terms to start doing this and confusing our users with multiple ontologies.

jamesaoverton commented 4 years ago

It's fine to add them to OBI. We now have a devices.tsv template.

jamesaoverton commented 4 years ago

Adding these in #1196 with the following IDs:

OBI:0002750 Oxford Nanopore MinION OBI:0002751 Oxford Nanopore GridION Mk1 OBI:0002752 Oxford Nanopore PromethION