obi-ontology / obi

The Ontology for Biomedical Investigations
http://obi-ontology.org
Creative Commons Attribution 4.0 International
75 stars 26 forks source link

Add logical axioms associated with 'data transformation' back? #1504

Open zhengj2007 opened 2 years ago

zhengj2007 commented 2 years ago

The 'data transformation' has following logic axioms before:

has_specified_input only 'data item'
has_specified_input some 'data item'
has_specified_output only 'data item'
has_specified_output some 'data item'

Now 'data transformation' only specify the input in axioms as: has_specified_input only 'data item'

The logic axioms removed may due to slowing down the reasoning. I performed the test in Protege using Hermit reasoner including: Pre-computing inferences:

has_specified_input only 'data item' Ontologies processed in 349574 ms by HermiT

has_specified_input some 'data item'
has_specified_output some 'data item'

Ontologies processed in 379260 ms by HermiT

has_specified_input only 'data item'
has_specified_input some 'data item'
has_specified_output only 'data item'
has_specified_output some 'data item'

Ontologies processed in 367654 ms by HermiT

If we added the logic axioms back, it will take about 20 seconds more. Considering reasoning is taking about 350 seconds (~6 min) now, I think 20 secs more is acceptable. So, I'd prefer to add them back.

zhengj2007 commented 2 years ago

Discussed on OBI call 2022-03-14. Prefer to go with:

has_specified_input some 'data item'
has_specified_output some 'data item'