obi-ontology / obi

The Ontology for Biomedical Investigations
http://obi-ontology.org
Creative Commons Attribution 4.0 International
75 stars 25 forks source link

unsatisfiability from COB interaction #1612

Open balhoff opened 1 year ago

balhoff commented 1 year ago

I'm trying to resolve unsatisfiable classes found in the Ubergraph build. This issue overlaps OBI, SO, and COB.

genotyping assay EquivalentTo Nothing

The core problem is that OBI is using region as a generically dependent continuant, but COB is asserting it to be a subclass of material entity. Who should change, OBI or COB? Could OBI change the axiom to something like:

cmungall commented 1 year ago

Slides from COB workshop: https://docs.google.com/presentation/d/1UhWNyZI6_4tc-xR2NXNAIaqBTDgOYLYCAG7emrkGmKY/edit#slide=id.gef3aeb5791_0_630

relevant issue: https://github.com/OBOFoundry/COB/issues/52

balhoff commented 1 year ago

Also want to note this isn't the only unsatisfiable OBI term in Ubergraph, just the only one I've output an explanation for. There are 98; it could be many of them are the same issue.

cmungall commented 1 year ago

looks like this is still an issue?

jamesaoverton commented 1 year ago

Discussed on the OBI call 2023-03-06: OBI would like to follow COB, and so we can put 'region' under 'material entity'. It would be better for SO to clean up their definitions, but that's their problem.

OBI has created two subclasses of 'region':

For now at least we will leave these as subclasses of 'region'. We may need to fix that later.

ddooley commented 1 week ago

Update: COB hasn't made commitment to including "region" and some other SO terms yet (ME or ICE discussion). May be discussed in 22/23 Sept 2024 discussion.

cmungall commented 1 week ago

COB has absolutely made the commitment, see

https://github.com/OBOFoundry/COB/blob/master/src/ontology/components/cob-to-external.tsv

SO sf (and this region) are material entities

For full context see the slides from the 2021 workshop where this was agreed on:

https://docs.google.com/presentation/d/1UhWNyZI6_4tc-xR2NXNAIaqBTDgOYLYCAG7emrkGmKY/edit#slide=id.gef3aeb5791_0_572

cmungall commented 1 week ago

the fix here is to change the OBI SO injection to be consistent with COB (this will be fixed when COB imports work smoothly but for now COB should be taken as SOT and we should align with it as far as possible)

jamesaoverton commented 1 week ago

That change to COB hasn't yet been released, but we'll try to get a new COB release soon. Our OBI-to-COB transition PRs do now put 'region' under 'material entity'.