obi-ontology / obi

The Ontology for Biomedical Investigations
http://obi-ontology.org
Creative Commons Attribution 4.0 International
74 stars 24 forks source link

remove fluorescence imaging assays as children of fluorescence detection assay #1628

Closed hectorguzor closed 1 year ago

hectorguzor commented 1 year ago

Hi @mgiglio99 and @nsuvarnaiari

As you know, I am working on cleaning up assays that are not consistent with definitions for SubclassOf (for assay) and detection technique. You can find the list of assays here. I provide the definitions for your reference below:

I have identified a few assays your team worked on that are not consistent with these definitions.

  1. fluorescence imaging-based cell morphology assay
  2. fluorescence imaging-based protein phosphorylation state assay
  3. fluorescence imaging-based cell viability assay
  4. fluorescence imaging-based apoptosis assay
  5. fluorescence imaging-based reporter gene assay
  6. fluroescence imaging-based cell cycle state assay
  7. fluorescence imaging-based cell proliferation assay
  8. fluorescence imaging multiplex cytological profiling
  9. fluorescence imaging-based drug synergy assay

Currently, these assays are inferred as children of ‘fluorescence detection assay’ and also use it as a detection technique. I recommend that all of these assays keep ‘fluorescence detection assay’ as a detection technique, but remove ('material entity' and ('bearer of' some fluorescence)) as a specified_input to avoid inference under ‘fluorescence detection assay’. That should make these consistent with the definitions above.

In some cases, we can specify their target entities to make it clearer that ‘fluorescence detection assay’ is being used as a detection technique. Below I provide suggestions for what the target entities of these assays could be based on my understanding of them. Let me know what you think.

  1. fluorescence imaging-based cell morphology assay: Target entity = (‘morphology' 'quality of' some cell )
  2. fluorescence imaging-based protein phosphorylation state assay: Target entity = ( protein ‘has quality’ some ‘phosphorylation”)
  3. fluorescence imaging-based cell viability assay: Target entity = (‘viability’ ‘quality of’ some cell)
  4. fluorescence imaging-based apoptosis assay: Target entity = ‘apoptotic process
  5. fluorescence imaging-based reporter gene assay: Should the target entity of this assay be ‘gene expression’?
  6. fluroescence imaging-based cell cycle state assay: Should the target entity of this assay be (‘part of’ some cell cycle)?

Let me know what you all think.

mgiglio99 commented 1 year ago

Discussed on Jan. 23 call: There was general agreement with Hector’s proposal to keep ‘fluorescence detection assay’ as a detection technique, but remove ('material entity' and ('bearer of' some fluorescence)) as a specified_input to avoid inference under ‘fluorescence detection assay’. Suvvi and Michelle will take a look at Hector’s suggestions for adding target entities to these terms and get back to him.