search

obi-ontology / obi

The Ontology for Biomedical Investigations
http://obi-ontology.org
Creative Commons Attribution 4.0 International
74 stars 24 forks source link

Add editor's note about relation b/t OBI & CHEBI: solvent/solvent role #1778

Closed sebastianduesing closed 1 month ago

sebastianduesing commented 2 months ago

Closes #1771. Adds an editor's note to OBI:"solvent role" specifying the difference between it and CHEBI:"solvent," using language proposed by @bpeters42.

turbomam commented 1 month ago

An editor note like this is a good way of adding clarity, but I beleive that, as of April 2024, roles and material entities are disjoint in ChEBI, and this particular editor note is actually misleading.

2024-04-22 OBI call It is concerning that roles and material entities in ChEBI may have been less clear in the past, and if a change was made, we don't know about it in this OBI call.

bpeters42 commented 1 month ago

I cannot reconstruct what I had looked at before, and @turbomam and @cmungall are completely right. We should not add this comment, and go back to the issue.

bpeters42 commented 1 month ago

Closing this PR to revisit the discussion on the issue itself.