obi-ontology / obi

The Ontology for Biomedical Investigations
http://obi-ontology.org
Creative Commons Attribution 4.0 International
74 stars 24 forks source link

Make language tags consistent #1793

Open cmungall opened 2 weeks ago

cmungall commented 2 weeks ago

Half the OBI definitions have lang=en, the others are plain literals/strings

➜  ontology git:(master) ✗ grep IAO_0000115 obi-edit.owl | grep -c lang=
656
➜  ontology git:(master) ✗ grep IAO_0000115 obi-edit.owl | grep -vc lang=
702

I don't think there is OBO guidance but I think intra-ontology consistency is always good, it seems your intent is to be explicit, I think it would be clearly safe to auto-convert all definitions to lang=en

turbomam commented 1 week ago

Background from @jamesaoverton

turbomam commented 1 week ago

@cmungall is explicitly calling out definitions, but this is equally applicable to the objects of other triples (like rdfs:label). There's some acknowledgement of that in the PR discussion.

This work will need to be applied to inputs other than obi-edit.owl, like ROBOT templates. The bare use of AL column headers (without specifying the language code like @en) isn't a complete solution.

turbomam commented 1 week ago

Attendees in today's meeting agree with the content of this PR and appreciate the clever implementation. The way Dragon AI modified the tab characters make break the expectations of the ROBOT template format.

I and or @sebastianduesing will build upon it.

turbomam commented 1 week ago

we'll finish this PR on definitions and start another one for labels.