Open cmungall opened 2 months ago
I think this has potential, but OBI:0400043 is a cytometry flow cell, not a sequencer flow cell. I'm pretty sure there's no such thing as a jet-in-air sequencer flow cell.
I like this but it will result in a lot of pre-composed classes over time. Who's going to maintain them, or keep the set complete?
I think we should share with Chris our issues we have had in trying to maintain definitions for instruments. We initially wanted to follow an approach like Chris has here, but the problems are that:
On Thu, Sep 12, 2024 at 11:35 AM Mark Andrew Miller < @.***> wrote:
I like this but it will result in a lot of pre-composed classes over time. Who's going to maintain them, or keep the set complete?
— Reply to this email directly, view it on GitHub https://github.com/obi-ontology/obi/issues/1820#issuecomment-2346625450, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADJX2ITKYXLZ33DBRON7T6LZWGYCNAVCNFSM6AAAAABOBXSD42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBWGYZDKNBVGA . You are receiving this because you are subscribed to this thread.Message ID: @.***>
-- Bjoern Peters Professor La Jolla Institute for Immunology 9420 Athena Circle La Jolla, CA 92037, USA Tel: 858/752-6914 Fax: 858/752-6987 http://www.liai.org/pages/faculty-peters
OBI's root DNA Sequencer class can be found here in OLS
Mark and I talked about this a bit offline, I care less about the flowcell IDs since it impacts throughput but not analysis. What I would like to see is 1) Illumina NovaSeq X added 2) Groupings by series (ex Illumina HiSeq, Illumina NovaSeq, etc), this makes the ontology easier to read and we have cases where we don't have the model number (ex we know it is illumina NextSeq but not if it is 500 or 550.
Both of those requests are straightforward to implement, and make perfect sense. I am hoping @turbomam can compile all the manufacturer / series you will need, and get it into OBI.
Illumina NovaSeq X was added recently in PR 1804, which will go live in the next OBI release.
I second the motion for grouping terms for the sequencer series. I've also run into situations of not knowing which exact member of the series is in play.
Discussed on Sept 30 call - general agreement that grouping terms for the sequencer series is a good idea. Mark is going to provide a table with info on related terms from different sources. He will propose grouping terms along the lines of this example: 'Illumina HiSeq Series sequencer' .
I have started two two new issues and propose closing this issue about flow cells
cc @turbomam
If we need to represent Illumina NovaSeq 6000 S4, I assume we would create a subclass of
id: OBI:0400043 name: flow cell def: "Aparatus in the fluidic subsystem where the sheath and sample meet. Can be one of several types; jet-in-air, quartz cuvette, or a hybrid of the two. The sample flows through the center of a fluid column of sheath fluid in the flow cell." [] synonym: "flow_cell" EXACT [] relationship: RO:0000085 OBI:0000370 ! contain function is_a: OBI:0000967 ! container
and then make a part_of link to the sequencer, eg.
id: OBI:0002630 name: Illumina NovaSeq 6000 def: "A DNA sequencer which is manufactured by the Illumina corporation, with two flow cells and an output of up to 6000 Gb (32-40 B reads per run). The sequencer utilizes synthesis technology and patterned flow cells to optimize throughput and even spacing of sequencing clusters." [] synonym: "NovaSeq 6000" EXACT [] is_a: OBI:0400103 ! DNA sequencer
Would this be a new robot template? E.g. something like: