obi-ontology / obi

The Ontology for Biomedical Investigations
http://obi-ontology.org
Creative Commons Attribution 4.0 International
75 stars 24 forks source link

Specimen related terms needed by MO #510

Closed obi-bot closed 7 years ago

obi-bot commented 14 years ago

Some MO terms were used in MAGE-TAB files to describe how the specimens which used for an microarray experiment were maintained.

Those terms were listed as fellow: agar_stab agar stab, a cell culture inoculated into agar for long term storage freeze_dried_sample A biomaterial that has been lyophilized or dried by freezing under a vacuum. fresh_sample A sample freshly obtained from the organism(s). E.g. a liver freshly removed from a rat. frozen_sample A biomaterial obtained frozen paraffin_sample A biomaterial obtained embedded in paraffin (wax).

All these material entities are the specified output of a storage process.

Suggest add to be subclasses of OBI_0100051 specimen with restriction: is specified output of some 'storage'

Labels and Definitions of terms will be modified if needed.

Reported by: zhengj2007

Original Ticket: obi/obi-terms/519

obi-bot commented 14 years ago

Design pattern

A X is a specimen that is the output of some storage process with an objective of material maintenance Need to create corresponding storage process and specify inputs and outputs

frozen_sample ------------- frozen specimen and freezing process have been added following the pattern. Suggest modify the label to freezing storage.

agar stab --------- An agar stab is a specimen that is output of an agar stab storage process An agar stab storage process is a storage process with input cell culture and agar and output agar stab.

paraffin_sample --------------- A paraffin specimen is a specimen that is output of a paraffin storage process. A paraffin storage process is a storage process with input organism or anatomical entity and paraffin and output paraffin specimen with an objective of material maintenance.

freeze_dried_sample ------------------- A freeze dried specimen is a specimen that is output of a lyophilized storage process which specimen is lyophilized for storage. A lyophilized storage process is a storage process with input material entity and output freeze dried specimen with an objective of material maintenance.

Actually, frozen, agar stab, paraffin embedded, lyophilization is a way to prepare the specimen for long term storage. So far, I think we do not need to distinguish storage preparation and real storage process to avoid over-modeling.

fresh_sample ------------ 'specimen' define by a specimen creation process with specimen creation objective which is to obtain and store a material entity for potential use as an input during an investigation Specimen creation process included both obtain and store processes. Can we modify specimen creation process which is to obtain or to obtain and store?

Fresh specimen is a specimen that is output of a specimen creation process without storage. Stored specimen is a specimen that is output of a specimen creation process with storage.

Or define fresh specimen using disjoint (Chris' suggestion) A fresh specimen is a specimen and is disjoint from stored specimen [ frozen specimen and agar stab and paraffin specimen and ..]

Any other suggestion?

Original comment by: zhengj2007

obi-bot commented 14 years ago

The terms were added. SVN revision: 2894.

All storage process classes were asserted under 'storage' because 'storage' and 'material maintenance' have no difference in logical definition. If classes were added under planned process, they were classified under 'material maintenance' instead of 'storage'.

The textual definition of 'specimen creation objective' were modified as suggested to fit 'fresh specimen'.

Tried to add the specimen classes under _defined_material as Alan did for 'frozen specimen'. Classification always failed due to 'run out of memory'. So, all these classed were added to be children of specimen. Also moved 'frozen specimen' under 'specimen' for consistency. The classification speed up about 3 folds after this modification (from 386 sec to 123 sec).

Restriction 'not (is_specified_output some storage)' was added to 'fresh specimen' for distinguish it with general 'specimen'. Any better suggestion would like to take.

Two more classes are needed for two storage process classes, 'paraffin' for paraffin storage and 'agar' fro agar stab storage.

Original comment by: zhengj2007

obi-bot commented 13 years ago

all needed terms are in OBI

Original comment by: zhengj2007

obi-bot commented 13 years ago

Original comment by: zhengj2007