obi-ontology / obi

The Ontology for Biomedical Investigations
http://obi-ontology.org
Creative Commons Attribution 4.0 International
74 stars 24 forks source link

Improve logic for DNA sequencing service #873

Open jamesaoverton opened 6 years ago

jamesaoverton commented 6 years ago

Before reasoning, OBI:0000992 DNA sequencing service currently appears under owl:Thing at the top of the class hierarchy, next to 'entity' and 'ObsoleteClass'. It's the only term with this problem, and it's bugging me.

After reasoning (and in the release files), it appears under sequencing service, which is correct.

To get it out from under owl:Thing, I think that its logical axioms:

subclass of: provides_service_consumer_with some 'DNA sequencing'
subclass of: realizes some 'service consumer role'
subclass of: realizes some 'service provider role'

should be removed and replaced by

equivalent to: 'service' and (provides_service_consumer_with some 'DNA sequencing')

We could use a more specific 'material service' or 'sequencing service'. Or we could just replace the two 'realizes' subclass axioms with one subclass of: service axiom.

jamesaoverton commented 6 years ago

Jie remembers this being used as an example of how the reasoner can properly classify a term. We can make the proposed change.