search

obi-ontology / obi

The Ontology for Biomedical Investigations
http://obi-ontology.org
Creative Commons Attribution 4.0 International
75 stars 26 forks source link

NTR: longitudinal study design #971

Open TrisSN opened 6 years ago

TrisSN commented 6 years ago

NTR: longitudinal study design Definition: A study design that involves repeated observations of the same entity over time. In the biobank context, longitudinal studies sample a group of people in a given time period, and study them at intervals by the acquisition and analyses of data and/or samples over time. [source: https://www.ebi.ac.uk/ols/ontologies/omiabis/terms?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FOMIABIS_0001019] Parent: study design Synonyms: long-term study design

bpeters42 commented 6 years ago

This looks good, we will add.

bpeters42 commented 6 years ago

Closed by accident.

turbomam commented 6 years ago

@TrisSN, this term already exists in the OMIABIS ontology. Can you import that ontology into your workspace in addition to OBI?

I have added http://purl.obolibrary.org/obo/OMIABIS_0001019 into our general OBO Ontofox input template, so if that modification is accepted, the term will be imported into OBI.

I'd just like to feedback from you, along with @cstoeckert @jamesaoverton and or @bpeters42, about the value of this term coexisting in OBI and OMIABIS.

jamesaoverton commented 6 years ago

OMIABIS imports a bunch of stuff from OBI, so this would be a circular dependency. That's workable but it makes me uncomfortable. We keep running into similar cases.

What do you think @mbrochhausen?

cstoeckert commented 6 years ago

I don't see the need to import the term into OBI. It exists already and is being maintained in OBIB so can be used by all without being in OBI.

bpeters42 commented 6 years ago

The request for 'longitudinal study design' was an external term request to OBI, based on the assumption that OBI covers study designs, which it definitely does. And I don't see why 'longitudinal study design', which is quite fundamental, would now not be in OBI. If it originated in OBIB / OMIABIS before, I guess that is okay, but we should provide it with the OBI release, as we cannot expect people to search for study designs in multiple locations due to different term origins. I would normally also say that something as general as longitudinal studies should definitely be in OBI as there is nothing at all biobanking specific about it.

On Mon, Oct 15, 2018 at 1:03 PM cstoeckert notifications@github.com wrote:

I don't see the need to import the term into OBI. It exists already and is being maintained in OBIB so can be used by all without being in OBI.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/obi-ontology/obi/issues/971#issuecomment-429993450, or mute the thread https://github.com/notifications/unsubscribe-auth/ANN9IoKicSDuK-cuzk-GbeEAdCJtBavmks5ulOopgaJpZM4XIKVk .

-- Bjoern Peters Professor La Jolla Institute for Allergy and Immunology 9420 Athena Circle La Jolla, CA 92037, USA Tel: 858/752-6914 Fax: 858/752-6987 http://www.liai.org/pages/faculty-peters

cstoeckert commented 6 years ago

It originated in OMIABIS and was inherited by OBIB. "we should provide it with the OBI release, as we cannot expect people to search for study designs in multiple locations due to different term origins" -point taken. It is certainly more general than biobanking.

ddooley commented 6 years ago

I see there is a distinction between "longitudinal study" (planned process) and "longitudinal study design" (plan specification). It would be a nice project for someone (student!) to make a core /recommended organization of all the study design types as processes and specifications. Right now NCIT has "activities" which -if one examines the defs appear to be specifications - that are competing with OBI etc. for an enumeration of these as a recent diagram shows. Relations are hypothetical. I'll have to add OBIB designs to diag.

decision_tree_datatypes

TrisSN commented 6 years ago

We have certain trusted ontologies that the tool we use allows. In general, OBI is our preferred one, so we'd very much like to see all 'design' terms supported in OBI. With respect to whether 'longitudinal study' & 'longitudinal study design', we treat them as different: in our Design Types, we would only use the latter. We probably wouldn't use the former anywhere. Perhaps the former is somewhat too constrained, as any 'design' can be used in conjunction with other 'designs'.

jamesaoverton commented 6 years ago

Action Item: James will adopt OMIABIS_0001019 into OBI.