search

obi1kenobi / cargo-semver-checks-action

A GitHub Action for running cargo-semver-checks
MIT License
60 stars 15 forks source link

Clarify caching inputs #77

Closed memark closed 4 months ago

memark commented 4 months ago

The documentation mentions shared-key and cache-key as an input, but the latter doesn't seem to exist. I've changed the wording to refer to prefix-key and shared-key instead.

memark commented 4 months ago

Anything more I can do here? I'm assuming the failing CI tests are unrelated to my docs change.

obi1kenobi commented 4 months ago

Indeed. Thanks for the ping!

It's an interesting failure due to GitHub Actions caching that caused an older commit that should have failed CI to incorrectly pass CI by using a previous run's cache: https://github.com/obi1kenobi/cargo-semver-checks-action/pull/79

After that PR merges, this CI should be green again. I'll keep an eye on it now and make sure it's all good.