Note the added ?Sized bound in the newer version. From caller side this is a non-breaking change as it only extends the set of allowed values. For existing implementations outside of diesel of the given trait this is a breaking change as it requires updating the function signature. It also might break an implementation that assumes that U is Sized.
Thanks, this is awesome! Especially appreciate the details on how this might be breaking and for whom, which will be super helpful writing the diagnostic message this should show.
Steps to reproduce the bug with the above code
Actual Behaviour
No breaking change is reported:
Expected Behaviour
Cargo semver-checks should report a major breaking change. A trait function added a
?Sized
bound to it's where clause.Documentation:
Relevant function signature: 2.0.4:
2.1.1:
Note the added
?Sized
bound in the newer version. From caller side this is a non-breaking change as it only extends the set of allowed values. For existing implementations outside of diesel of the given trait this is a breaking change as it requires updating the function signature. It also might break an implementation that assumes thatU
isSized
.Generated System Information
Software version
cargo-semver-checks 0.22.1
Operating system
Linux 6.4.7-200.fc38.x86_64
Command-line
cargo version
Compile time information
Build Configuration
No response
Additional Context
No response