search

obi1kenobi / trustfall

A query engine for any combination of data sources. Query your files and APIs as if they were databases!
Apache License 2.0
2.3k stars 66 forks source link

feat: Refactor test suite for trustfall_wasm [WIP] #555

Open devanbenz opened 4 months ago

devanbenz commented 4 months ago
devanbenz commented 4 months ago

LOL @ // Currently failing because of the "export" keyword in iterify(). comment in the node test suite 😆 gotta love javascript and its inability to have the same package management system in both node and web

obi1kenobi commented 4 months ago

LOL @ // Currently failing because of the "export" keyword in iterify(). comment in the node test suite 😆 gotta love javascript and its inability to have the same package management system in both node and web

Yeah, it's been really frustrating to be honest. Real Python 2 vs Python 3 vibes.

devanbenz commented 4 months ago

Will be coming back to this PR over the weekend! I was out of town last week/over the weekend :D

obi1kenobi commented 3 months ago

Hey! Just checking in to see if you're still thinking about working on this, or if you got blocked on something I could help with.

No worries if you had other stuff come up, or if for whatever reason you can't work on it anymore. Stuff happens, and I appreciate your help here!

devanbenz commented 3 months ago

Hey! Yeah I've been really busy with work lately 🙃 If someone else is interested in taking this on feel free to reassign. I'm hoping to have some more free time after I finish up a project that's "crunch time" at work.

obi1kenobi commented 3 months ago

No rush! If you're still interested in this, it's all yours. Good luck with the crunch time project!

devanbenz commented 3 months ago

No rush! If you're still interested in this, it's all yours. Good luck with the crunch time project!

Definitely still interested - would love to contribute more as I start to have more free time in the next coming weeks :D