obiba / agate

OBiBa's user ID provider.
GNU General Public License v3.0
4 stars 7 forks source link

reset-password-proposal by administrator to new user fails #446

Closed dmkuzsib closed 3 years ago

dmkuzsib commented 3 years ago

Hi,

I am using Agate 2.2. If administrator proposes to reset [non-existing yet] password to new self-registered user via "Actions" menu on "Users" page, an error occurs. If password is beforehand set by administrator, a reset-password-proposal goes OK.

Not sure if this is the feature, not a bug... IMHO useless for administrator to type in new password to be then reset by the user.

thanks, Dmitry.

kazoompa commented 3 years ago

Hi,

Can you provide more information? Possibly the error in the /var/log/agate/agate.log.

Normally, this action should result in an email sent to the user in question, is your server setup properly for sending mails?

Best,

On Wed, May 12, 2021 at 4:45 AM dmkuzsib @.***> wrote:

Hi,

I am using Agate 2.2. If administrator proposes to reset [non-existing yet] password to new self-registered user via "Actions" menu on "Users" page, an error occurs. If password is beforehand set by administrator, a reset-password-proposal goes OK.

Not sure if this is the feature, not a bug... IMHO useless for administrator to type in new password to be then reset by the user.

thanks, Dmitry.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/obiba/agate/issues/446, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVPF7AP6GLRMLS3JOTYQT3TNI54NANCNFSM44YEEJ6A .

dmkuzsib commented 3 years ago

Hello,

My attempt to reset password ends up with a nice self-explaining note "Error!" on an otherwise empty page with Agate theme. Zero records in agate.log

Emailing is, of course, configured on the server and does deliver messages, e.g. when new user is self-registered or the user's [previously set by administrator] password is reset. thanks, Dmitry. image

kazoompa commented 3 years ago

The reason for the error is that user status is in pending and the resetPassword fails as the server cannot find any credentials for the new user and an exception is thrown:

if(userCredentials == null) throw new BadRequestException("User has no defined credentials.");

We could send a better error message or as in Mica, have a configuration in Agate to let the newly registered user assign a password.

dmkuzsib commented 3 years ago

have a configuration in Agate to let the newly registered user assign a password.

yes or just let user type a password while self-registering

kazoompa commented 3 years ago

This issue is no longer reproducible with the fix #450, the password reset button won't show when a user's status is not active.

dmkuzsib commented 3 years ago

Does changing user status from Pending to Active also assigns user a temporary password, or administrator still should type in one? IMHO useless to assign an unknown to user password without means to communicate it to the user. Assigning a random one is a better option.

kazoompa commented 3 years ago

Reset password sends an email to the user for a password input.

On Tue, May 18, 2021 at 4:57 AM dmkuzsib @.***> wrote:

Does changing user status from Pending to Active also assigns user a temporary password, or administrator still should type in one? IMHO useless to assign an unknown to user password without means to communicate it to the user. Assigning a random one is a better option.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/obiba/agate/issues/446#issuecomment-842989039, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVPF7AC4TSDIJERHJ46JJTTOITXRANCNFSM44YEEJ6A .