search

obiba / docker-opal

GNU General Public License v3.0
7 stars 11 forks source link

Docker - obiba/opal:4.5 #22

Closed jonathanmassehsj closed 1 year ago

jonathanmassehsj commented 1 year ago

Describe the bug

Opal version 4.5.5

After every restart the settings (only the line) ( org.obiba.real.url ) in opal-config.properties is lost.

Other lines dont have this issue, not sure why the file is overwriting this line.

To Reproduce Steps to reproduce the behavior: docker restart "dockerid"

Expected behavior Keep org.obiba.realm.url line and have agate working with opal.

jonathanmassehsj commented 1 year ago

Opal 4.5.4 don't have this issue, not sure why.

ymarcon commented 1 year ago

I cannot reproduce on opal-demo.obiba.org and nothing has changed on that setting, probably for years.

ymarcon commented 1 year ago

Try to inquire why the first_run.sh script is run after the restart (not supposed to happen if the file /opt/opal/bin/first_run.sh.done exists). This is the code where agate url is set or disabled:

https://github.com/obiba/docker-opal/blob/master/bin/start.sh#L46-L69

jonathanmassehsj commented 1 year ago

Thank you @ymarcon, you're the best, it was the issue, you definitely saved me alot of time.

I added a definition for the environment variable (in the docker-compose) of opal and it fixed the issue. I think maybe someone manually defined the environement variable in the old version 4.5.4 by running a bash command line and that's why it was working, so when I recreated the container it reseted the environment variable that was not in part of the docker-compose.xml

Is there any reason why if it's not defined, it's erasing the config file? Maybe it's would be better to remove the 3 lines in https://github.com/obiba/docker-opal/blob/master/bin/start.sh#L66-L68

Also the docker-compose.xml never show the variables AGATE_HOST and AGATE_PORT, (this is where I added the two missing variables)

https://github.com/obiba/docker-opal/blob/master/docker-compose.yml#L15-L33

Many thanks again

ymarcon commented 1 year ago

If the "org.obiba.realm.url" is not set to empty, opal will keep on trying to connect to agate and issue confusing error messages.