obiba / docker-opal

GNU General Public License v3.0
7 stars 11 forks source link

Missing agate environment variables in docker-compose.xml #23

Closed jonathanmassehsj closed 1 year ago

ymarcon commented 1 year ago

I don't think it is necessary: Agate is optional for Opal, there is no Agate defined in this docker compose file and using agate-test is misleading.

jonathanmassehsj commented 1 year ago

If you need agate and you don’t define the variable, it will get overwrited in file opal-config.properties when the docker start in (start.sh)

jonathanmassehsj commented 1 year ago

Maybe a comment saying that if you need agate uncomment the required lines in the docker-compose.xml would help

ymarcon commented 1 year ago

I understand your concern with the agate setting but this docker file aims at defining a stand alone opal instance, i.e. without agate: it is expected that no agate variables are defined in this file.