search

obiba / mica2

Mica is a web portal for epidemiological study consortia.
http://www.obiba.org/pages/products/mica/
GNU General Public License v3.0
10 stars 15 forks source link

Cannot Cancel Rejection of a Feasibility #4365

Closed kazoompa closed 1 year ago

kazoompa commented 1 year ago

Describe the bug Cannot cancel rejection of feasibility form not even as an administrator.

To Reproduce

  1. Login as a regular user
  2. Create a DAR
  3. Create a feasibilty form and submit
  4. Login as a DAO
  5. Reject feasibility form
  6. Click on Cancel Rejection

Expected behavior Feasibility form's rejection is cancelled

Current behavior Mica rejects the request due to:

java.lang.IllegalArgumentException: Rejected data access form can only be put under review

All Data Access entities share the same DataAccessRequestUtilService::checkRejectedStatusTransition. Maybe this logic should only apply to DAR and AMD.