obiba / mica2

Mica is a web portal for epidemiological study consortia.
http://www.obiba.org/pages/products/mica/
GNU General Public License v3.0
10 stars 15 forks source link

Cannot update/replace internal taxonomy #4422

Open johannes-darms opened 12 months ago

johannes-darms commented 12 months ago

This issue is unique

Version information

SNAPSHOT and 5.2.3

Expected behavior

As an instance administrator In order to change labels, descriptions and hide properties of an internal taxonomy I want to update taxonomies via the web UI. The versions that I've uploaded should have precedence over the internal ones.

Actual behavior

Once I upload a file with the same name (filename and name within the yml) the taxonomy is indexed and exposed via the /ws/taxonomies/_filter API. This works as expected. However, the response contains two entries with the same name, the internal one and the just supplied one. Hence, the internal entry is not overridden and the UI uses the internal one.

I believe the source of this behavior is https://github.com/obiba/mica2/blob/bf9efc77d48a6414594b38b1a8356c564ec7a6ce/mica-search/src/main/java/org/obiba/mica/taxonomy/TaxonomyIndexer.java#L78.

Reproduction steps

Take a taxonomy from mica-core/taxnomies(e.g. mica-variable). Alter the file (remove an attribute) Upload the taxonomy via the admin UI.

Operating System (OS)

Linux

Browser

No response

Contact info

No response