search

obiba / onyx

Web-based application that manages participant baseline interviews at assessment centres or clinics.
http://www.obiba.org/pages/products/onyx
GNU General Public License v3.0
6 stars 13 forks source link

ONYX-543: Improve behaviour of Tanita Instrument Runner when required parameter is null/missing #567

Closed ymarcon closed 6 years ago

ymarcon commented 15 years ago

Jira issue originally created by user @plaflamme:

Currently, the Bc418InstrumentRunner doesn't check that some parameters are non-null before sending to the tanita.

Results in throwing an exception without much information to determine what the problem is.

The log should at least contain a message stating that a parameter was null when it was expected to be non-null and provide the parameter name.

ymarcon commented 15 years ago

Comment created by nemond:

Ready to test

ymarcon commented 15 years ago

Comment created by dspathis:

Tested -- one issue found. We are handling the condition where a parameter does not exist, not where the parameter exists but has a null value. In the latter case an exception is thrown only later on when we try to send the null parameter value to the device.

ymarcon commented 15 years ago

Comment created by dspathis:

See earlier comment.

ymarcon commented 15 years ago

Comment created by acarey:

fixed

ymarcon commented 15 years ago

Comment created by nemond:

ready to retest!

ymarcon commented 15 years ago

Comment created by dspathis:

Verified - no issues.

ymarcon commented 15 years ago

Issue was closed with resolution "Fixed"