jlberbesi
commented
1 year ago Hey there, @obibaadoma! 👋 I hope you're doing well. I wanted to take a moment to commend you on the fantastic work you've been doing with your TO DO IT project! 🌟 It's clear that you've put in a lot of effort and dedication.
Now, I've gone through the project and prepared a brief review for you. Let's dive into it, and I hope you find the feedback helpful and encouraging! 🕵️♂️ Keep up the great work, and I'm excited to discuss the review with you. Happy coding! 🚀😄
JavaScript Best Practices: The JavaScript code looks pretty clean and well-structured. Great job! I do, however, have a small suggestion. Adding some comments to explain the purpose of certain functions or sections of the code would be helpful for better code readability and future reference. Overall, though, you're doing well with the JavaScript best practices! 📝
DRY, KISS, and YAGNI Rules: I must say, your code is DRY and KISS compliant! There are no noticeable instances of repetition, and you've kept the code simple and straightforward. Excellent work! Moreover, you've nailed the YAGNI principle – everything seems essential and purposeful for the current functionality. Keep it up! 💪
HTML & CSS Best Practices:
The HTML structure is pretty neat and organized. However, consider using semantic elements like <main> instead of <div class="list-con"> to improve accessibility and SEO. As for CSS, I noticed the provided code snippet doesn't include any styles, but just a heads up – when you add them, make sure to keep the styles modular and well-organized. Also, consider avoiding overly specific selectors to keep the CSS maintainable. Adding comments to the CSS can be useful too! 🎨
Summary: Overall, your code looks solid! You've done a great job with JavaScript best practices, keeping it DRY, KISS, and YAGNI-compliant. Just a little tweak with adding comments for code explanation and considering semantic HTML elements will make it even better. Keep up the fantastic work, and I can see you're on the right track as a developer! Happy coding! 🚀😄
Great job so far, but there a few things i will like you to consider.
[ ] I realised you didn't follow any particular naming conventions when declaring a variable in JavaScript. I suggest you use a particular naming standard in all subsequent projects. [ ] Kindly use appropriate links in readme file and also include the licenses. [ ] Please fix the local storage problem, you can try putting a load event in your task class.