search

obidient / 23ForObiApi

MIT License
4 stars 8 forks source link

this commit fixes #6 #12

Closed blacdev closed 2 years ago

blacdev commented 2 years ago

It also covers issues with modules not included in the Bigfast build closes #6

blacdev commented 2 years ago

@phemmylintry

blacdev commented 2 years ago

@nseetim @odizee can i get a reason why this has not been merged yet?

samsoft00 commented 2 years ago

Hey @blacdev , your MR look strange, why do you update requirement file? Do you read readme file on how to set this up?

blacdev commented 2 years ago

The requirements file covers all the modules/library needed in bigfast. This is because i am currently one of the contributors and i know and have experienced issues with not having all the modules installed. That is why i added it @samsoft00

samsoft00 commented 2 years ago

I understand you @blacdev, but I think we can fix any issue right from bigfat.

Also, things seems to be working perfectly from my side, I didn't install any other package aside the basic requirements.

@phemmylintry can you help us look into this?

blacdev commented 2 years ago

Okay then. I'll take them out now. @samsoft00

phemmylintry commented 2 years ago

@samsoft00 @blacdev I noticed some packages are still missing even when I installed bigfast directly, I don't know why that is but it doesn't hurt to have all the requirements there just to be double sure. bigfast itself is currently ongoing changes every time. So we don't break production. Thanks

blacdev commented 2 years ago

@phemmylintry i'll add it back. Do i also add a better env.sample file that covers all env variables?

phemmylintry commented 2 years ago

@blacdev Error from google when testing with keys

image