search

obipawan / react-native-dash

A super simple <Dash /> component for react-native to draw customisable dashed lines
176 stars 64 forks source link

updating const to let #15

Closed ahmedu007 closed 6 years ago

ahmedu007 commented 6 years ago

I'm using this lib with react-native-web. Its not letting me compile since the const is being redefined in the function. Updating the const to a let to solve the issue and fix the convention.

NsTremblay commented 6 years ago

This was causing react-native 0.56 to crash. Had to apply this patch in order to make it work.

jmikulka commented 6 years ago

@ahmedu007 could you please update your commit to include the change from const to let only?

@obipawan I can confirm this fix works on react-native@0.56.0, would you mind merging it and publishing new version to npm?

luskin commented 6 years ago

@obipawan Can you please merge this in? Confirmed this is a RN 0.56 issue and that simple one line fixes it.

simulator screen shot - iphone 6 - 2018-07-16 at 10 44 37

obipawan commented 6 years ago

Apologies folks. I'll be pushing out an update in some time.

obipawan commented 6 years ago

Available on v0.0.9 Thanks @ahmedu007 for the fix