search

obipawan / react-native-hyperlink

A <Hyperlink /> component for react-native that makes urls, fuzzy links, emails etc clickable
MIT License
801 stars 76 forks source link

Dot app domains not linked without http(s) #54

Closed robertgaal closed 2 years ago

robertgaal commented 4 years ago

Describe the bug A dot app domain (get.app) isn't linked without also adding http or https (https://get.app). This is however true for dot com (github.com / https://github.com) domains and others.

To Reproduce Steps to reproduce the behavior:

  1. Input string "get.app and https://get.app"
  2. "get.app" is not linked

Expected behavior

  1. "get.app" is linked

Screenshots Screen Shot 2020-08-27 at 15 55 17

obipawan commented 4 years ago

Seems like a duplicate of https://github.com/obipawan/react-native-hyperlink/issues/19#issuecomment-354412306. Give this a shot?

robertgaal commented 4 years ago

Thanks for the lightning fast response!

I can definitely add a custom handler. But note that when I for instance use .com or .co or .nl, this works as intended. It's just .app where this fails.

Are you saying I should file a bug with linkify-it instead to support the dot app TLD? It appears they use node-tlds and that does have dot app included.