search

obipawan / react-native-hyperlink

A <Hyperlink /> component for react-native that makes urls, fuzzy links, emails etc clickable
MIT License
801 stars 76 forks source link

linkDefault no longer works on iOS with Expo SDK 39 #56

Closed karanmartian closed 2 years ago

karanmartian commented 4 years ago

Only on iOS seeing this issue, have to explicitly mention Linking.openURL in onPress func. This is after upgrading to RN Expo 39.0.0 SDK

rrufus commented 4 years ago

It also appears not to work on iOS14.1 with RN Expo 38.0.0 SDK, but explicitly mentioning Linking.openURL had no effect.

I'm going to try updating to Expo 39.0.0 SDK in the hope that the workaround of using onPress works there.

eladcandroid commented 3 years ago

Any news?

ShaneKeney commented 3 years ago

Also have a project that is running RN Expo 39.0.0. On iOS I am noticing that the onPress seems to not fire. The onLongPress does fire though.

A workaround here is to add your own Linking logic but I'd rather have a fix for the onPress to fire correctly.

obipawan commented 3 years ago

This is weird. I don't have an iOS device atm, I'm hoping this is reproducible on the simulators?

ShaneKeney commented 3 years ago

@obipawan Also noticed that this is only occurring for situations where Google Chrome is set as default browser. When I set my default browser to Safari, it works per usual.

KMKoushik commented 3 years ago

@ShaneKeney I am having the same issue as chrome is set as the default browser. Did you find any solution for this?

KMKoushik commented 3 years ago

Never mind it can be fixed by doing this step

https://github.com/obipawan/react-native-hyperlink/issues/57#issuecomment-733001152

ShaneKeney commented 3 years ago

@koushikmohan1996 We used Expo managed workflow so that solution wouldn't work for us directly. I'll have to check to see if that is configurable param for Expo app.json config. Otherwise we may just build out our own.

KMKoushik commented 3 years ago

@koushikmohan1996 We used Expo managed workflow so that solution wouldn't work for us directly. I'll have to check to see if that is configurable param for Expo app.json config. Otherwise we may just build out our own.

Okay. I was facing many issues like this while using expo. That's the main reason I moved to bare react native. :)

ShaneKeney commented 3 years ago

This issue seems to be resolved now. No longer facing these issues.