search

obivandamme / Workshop

This is the repository for the OSE Workshop mod for Kerbal Space Program
Other
11 stars 16 forks source link

Duplicate resource displays on surface scanner part #41

Closed Wyzard256 closed 6 years ago

Wyzard256 commented 7 years ago

OSE Workshop patches the stock "Surface Scanning Module" to have resource scanners for Dirt, ExoticMinerals, and RareMetals. However, recent versions of CommunityResourcePack already patch the surface scanner to show all the resources. OSE bundles an old version of CRP which doesn't do that, but for players who've installed a newer CRP (e.g. bundled with other mods), the surface scanner ends up having duplicate displays for those resources:

ose-duplicate-resources

After updating the bundled CommunityResourcePack to a newer version, the @PART[SurfaceScanner] patch in MM_Workshop.cfg ought to be removed.

On a related note, OSE also patches the stock orbital resource scanner for the same three resources, but this seems to have no effect, and the orbital resource scanner shows all resources anyway. I think this patch is a hold-over from KSP 1.1 (before KerbNet, when the orbital resource scanner worked differently), and it should probably be removed too.

Wyzard256 commented 6 years ago

Correction to my last paragraph above: the patch for the orbital resource scanner does have an effect — it shows the resource concentrations when the scanner is activated (i.e. rotating) — and can still be useful since it shows the concentrations even when there's no CommNet connection (so KerbNet is unavailable). So it's reasonable to keep that patch.

Wyzard256 commented 6 years ago

The fix for this was merged months ago, but I forgot (until now) to close the issue.