obiwan007 / despresso

GNU General Public License v3.0
75 stars 10 forks source link

Update weight listener complete heuristic #215

Closed tpict closed 4 months ago

tpict commented 4 months ago

We're currently using the flow rate forecast to determine when to pull the final weight of the shot. This doesn't always work well, since the forecast is so noisy.

This PR changes the heuristic "has the range of weight values measured over the last second dropped below 0.1g?"

This doesn't appear to make any difference to the time between the machine exiting the pour state and the visualizer upload happening. I guess there's some other bottleneck there.

denschub commented 4 months ago

This worked on a quick test just now. Pulling a turbo, the in-app espresso diary stopped at 38.9g, but both the scale and now visualizer correctly track 40.9. I agree with Tom that this doesn't make a noticeable difference in "how long do I have to wait for me to pick up the cup" time.