Query order execution fix

object-layer / cordova-sqlite-plugin

Cordova SQLite plugin with a straightforward low-level API

Other

5 stars 15 forks source link

Query order execution fix #11

Open andreamaioli opened 5 years ago

andreamaioli commented 5 years ago

Hi Manuel, thanks for your sqlite plugin.

We have spotted a problem in the order of query execution, which is not guaranteed if the workload is high. This is because the runInBackground method uses a concurrent queue, not a serial one.

The proposed changes solve the problem by serializing the queries directly in the plugin.

mvila commented 5 years ago

Thanks @andreamaioli for this PR, but the native part of this plugin comes from cordova-sqlite-storage, and since I am not very comfortable with this part (I coded only the JavaScript wrapper), I'd prefer to stick to the original code.

Do you know if your issue has already been fixed in cordova-sqlite-storage? If so, I could just update this plugin with the latest version.