Fix Windows Build CMP0135 Policy Deprecation

objectbox / objectbox-dart

Flutter database for super-fast Dart object persistence

https://docs.objectbox.io/getting-started

Apache License 2.0

918 stars 116 forks source link

Fix Windows Build CMP0135 Policy Deprecation #579

Closed ikelly963 closed 4 months ago

ikelly963 commented 5 months ago

Addresses #522

Regarding this Policy: https://cmake.org/cmake/help/latest/policy/CMP0135.html Setting Policy: https://cmake.org/cmake/help/latest/command/cmake_policy.html#setting-policies-explicitly

[x] I've read and followed CONTRIBUTING.md

ikelly963 commented 5 months ago

First time contributing to a public GitHub repo. Please let me know if I need to do something additional.

greenrobot-team commented 5 months ago

Thank you! I'll have a look when I have time.

For me: from a first look the used option is not added until 3.24, but the minimum supported CMake is lower. Check how that works on older versions. Also the docs note that enabling specific policies is discouraged.

ikelly963 commented 5 months ago

Ok, great. I'll take a look at those docs and figure out why these checks* are failing later, potentially today.

greenrobot-team commented 5 months ago

@ikelly963 Don't worry about the failling checks. pana fails because I need to still adjust the threshold and coverage just has no permission to upload the report because this is a branch outside of this repo.

greenrobot-team commented 4 months ago

The Flutter folks have a better fix. But I'm not sure it's still needed. See https://github.com/objectbox/objectbox-dart/issues/522#issuecomment-1849712951