objectbox / objectbox-go

Embedded Go Database, the fast alternative to SQLite, gorm, etc.
https://objectbox.io
Apache License 2.0
1.1k stars 45 forks source link

Incorrect result when querying against date field #19

Closed rerosum closed 4 years ago

rerosum commented 4 years ago

Please see attached sample project with failing test case. testObjectBox.zip

vaind commented 4 years ago

Go's time.Time struct is a complex type and requires a "converter" to store in the database. This converter is (as of ObjectBox Go 1.1) assigned automatically and used when storing and retrieving the data.

However, the query expects the already converted value (see func (property PropertyInt64) GreaterThan(value int64) Condition). There are no methods generated for the custom/complex type when using converters - the query methods expect the actual stored type & data.

Therefore, the usage in the failing test should look like this instead:

func TestGreaterThanDate(t *testing.T) {
    storedTime, err := objectbox.TimeInt64ConvertToDatabaseValue(t2)
    if err != nil {
        t.Error(err)
    }
    q := personBox.Query(
        person.Person_.Time.GreaterThan(storedTime),
        person.Person_.Time.OrderAsc(),
    )
    people, _ := q.Find()
    if people[0].Time.Unix() != t1.Unix() {
        t.Errorf("Expected t1 (%d) but got %d\nt0: %d, t1: %d, t2: %d", t1.Unix(), people[0].Time.Unix(), t0.Unix(), t1.Unix(), t2.Unix())
    }
}

With TimeInt64ConvertToDatabaseValue being one of the few built in converters you can use instead of defining a custom one.

Thanks for pointing this out. We will update the docs to mention this and also create an internal issue to track whether there can be something helpful done using code generation.

vaind commented 4 years ago

Updated docs: https://golang.objectbox.io/custom-types#queries

rerosum commented 4 years ago

Thanks for the clarification.