objectcomputing / check-ins

Other
7 stars 7 forks source link

Create a service for manipulating settings values #2355

Closed mkimberlin closed 3 weeks ago

mkimberlin commented 1 month ago

As a System Administrator, I want REST services to manage setting values, so that I can configure the application's behavior through the API.

Acceptance Criteria:

jackkeller commented 1 month ago

@mkimberlin is there an idea of the different settings that we'll want to have control over? Mainly asking to anticipate what we'll be needing on the #2356 side of things.

mkimberlin commented 1 month ago

I think there are a few categories of settings we will likely see out of the gate; one could be theming-related settings potentially (logo, primary/secondary/tertiary colors, etc.), another could be enabling and configuring various integrations (mailjet for example), and there might be some other values from our run.sh script variables that would be better served as admin configurable.

mjperry91 commented 4 weeks ago

@mkimberlin since the PUT endpoint requires us to pass a valid setting object to it, I have left this endpoint as /services/settings instead of adding the name path variable as we can just get that from the object and also verify the ID.

mjperry91 commented 4 weeks ago

PR: https://github.com/objectcomputing/check-ins/pull/2405