objectcomputing / check-ins

Other
7 stars 7 forks source link

(Backend) - Adding a New Guild Does Not Send Emails For Initial Lead Members #2363

Open mjperry91 opened 2 weeks ago

mjperry91 commented 2 weeks ago

Describe the bug When adding a new guild with at least 1 lead will not send an email to that lead, or any additional members that where initially there on create. When editing/updating an existing guild by adding a new member or lead emails will be successfully sent. This appears to be an issue in the GuildServicesImpl::save method.

To Reproduce Steps to reproduce the behavior:

  1. Go to Directory/Guilds & Communities
  2. Add new guild
  3. Ensure you have at least 1 lead, and add some additional members
  4. Observe no API calls are made to send emails.
  5. NOTE: when local testing if you do not have a mail jet api key you will see an error when the server attempts to send emails. This isn't a problem, and is a way for you to verify the server is trying to send an email. Error Example: Failed to send emails for [[{"Email":"someemail@objectcomputing.com"}]]

Expected behavior Emails should be sent to any lead/members upon initial creation of the guild, or there is a chance they will never be notified.