search

objectcomputing / check-ins

Other
7 stars 7 forks source link

(Backend) - Sending Feedback Notification Reports Success Despite Underlying Failure In Server To Send Email #2364

Closed mjperry91 closed 1 week ago

mjperry91 commented 2 weeks ago

Describe the bug When sending a notification reminder for an existing review feedback the backend will report a 200 ok status despite an underlying error occurring with mailjet that results in the email actually failing to be sent.

To Reproduce Steps to reproduce the behavior:

  1. Run on local and ensure you don't have a mailjet api key set to ensure email fails to send.
  2. Go to feedback/view feedback
  3. Click the drop down carrot on an individuals feedback
  4. Click the notification bell icon to send a request.
  5. Observe you get a successful green popup that says the notification was sent, when in fact if you look at the logs you will see a mailjet failure error.

Expected behavior If an email fails to send the server should report this to the UI.

mjperry91 commented 2 weeks ago

https://github.com/objectcomputing/check-ins/pull/2389