The grace period logic used considered a date of May 1st in the Q1 check-in logic. This was caused due to unexpected behavior adding a 1 month grace period. To address this issue, we instead use 30 days as the grace period.
Adds a test case which expresses the bug:
Q1 check-in date: Feb 12
Q2 check-in date: May 1
Before this update May 1 was being selected as the check-in for both the Q1 and Q2 reporting periods.
After this update May 1 is no longer selected as the check-in for the Q1 reporting period (Feb 12 is, as expected).
Depends on: https://github.com/objectcomputing/check-ins/pull/2402 ✅
The grace period logic used considered a date of May 1st in the Q1 check-in logic. This was caused due to unexpected behavior adding a
1 monthgrace period. To address this issue, we instead use 30 days as the grace period.Adds a test case which expresses the bug: Q1 check-in date: Feb 12 Q2 check-in date: May 1
Before this update
May 1was being selected as the check-in for both the Q1 and Q2 reporting periods. After this updateMay 1is no longer selected as the check-in for the Q1 reporting period (Feb 12 is, as expected).