search

objectcomputing / check-ins

Other
7 stars 7 forks source link

Feature 2237 clean up FindByFields #2452

Closed mjperry91 closed 3 weeks ago

mjperry91 commented 4 weeks ago

closes: https://github.com/objectcomputing/check-ins/issues/2237

mjperry91 commented 3 weeks ago

@mkimberlin the createdById search parameter for these GET endpoints doesn't appear to be used in the UI for all cases (agenda item), but I see a couple places it looks like its being passed in. This PR just cleans up the code as the logic was difficult to follow. We could remove it from the endpoints where the UI isn't using it, but figured it was safe to just preserve the functionality and verify it had tests.