objectcomputing / check-ins

Other
7 stars 6 forks source link

Launching a review period with no visible members #2746

Closed ocielliottc closed 1 week ago

ocielliottc commented 2 weeks ago

Describe the bug If a review period is created and approved, but then subsequently launched by a member that is not a reviewer, the UI will not allow it unless the "Show All" switch is on so that the review period members are visible.

To Reproduce Steps to reproduce the behavior:

  1. Go to FEEDBACK
  2. Click on Reviews
  3. Create a review period, fill in the dates, and add a single member where the review is not the current user.
  4. Request approval.
  5. Go back to that review and approve the reviewer.
  6. Ensure that the "Show All" switch is off.
  7. Click Launch Review
  8. The launch will not happen and you will see an error message stating that no members have been added.

Expected behavior The review should be able to be launched even if the members are not currently visible.

Screenshots no_members showing_members