search

objectionary / eo-threads

EO Objects for Managing Execution Threads
MIT License
13 stars 4 forks source link

50 thread.start #64

Closed levBagryansky closed 2 years ago

levBagryansky commented 2 years ago

50

Changed thread.start so now it returns the thread instead of TRUE Also now repeated start do nothing.

levBagryansky commented 2 years ago

@yegor256 please have a look

yegor256 commented 2 years ago

@levBagryansky maybe it's better to rename it to started now?

levBagryansky commented 2 years ago

@yegor256 thread.started does not return new thread, maybe it can confuse a user.

yegor256 commented 2 years ago

@levBagryansky in this case it's better to not return a thread at all. method name should mean what the method returns.

levBagryansky commented 2 years ago

@yegor256 ok I'll rename it

levBagryansky commented 2 years ago

@yegor256 please check

yegor256 commented 2 years ago

@rultor merge

rultor commented 2 years ago

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 2 years ago

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 12min)